Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Attempting to resize when toolbar has been turned off causes an unhandle... #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

sjhorst
Copy link

@sjhorst sjhorst commented Jan 28, 2015

Attempting to resize when toolbar has been turned off causes an unhandled exception.

@tacaswell tacaswell added this to the v1.4.x milestone Jan 29, 2015
@tacaswell
Copy link
Member

can you drop the second commit from this PR (the first commit is not controversial and I will merge strait away).

Want to do a bit of digging as to the source of that limit. I suspect that it is to prevent making the window arbitrarily small which may cause AGG to have conniptions as it tries to render your entire figure in a 3px wide box.

@sjhorst
Copy link
Author

sjhorst commented Jan 29, 2015

Done. Perhaps if the limit needs left in there it should be set to a hard minimum value such as 10px rather than a sizable percentage of the original specified height and width. I did some quick (albeit very incomplete) testing and there didn't seem to be a functional problem with rendering a histogram plot down to a few 10s of pixels.

tacaswell added a commit that referenced this pull request Jan 29, 2015
    BUG : fix tk resizing with toolbar
@tacaswell
Copy link
Member

Thanks!

I merged just the first commit (not the second and the reversion of it) on my local machcine as 4ed6cf3.

Can you open a new PR with re-size limit change? It is best if you put in a PR from a feature branch (that is a branch called anything but master/v1.4.x).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants