Propose removing minimum window size limit in tkAgg backend #4052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why this was in here in the first place, but it goes wayyy back. |
| # sizable percentage of the original dimensions (as implemented | ||
| # in v1.4.2 and prior) to allow initially large windows to | ||
| # shrink | ||
| # self.window.minsize(10, 10) |
There was a problem hiding this comment.
No need for this, nor the comment. I like PRs where code gets deleted. 👍
tacaswell
added a commit
that referenced
this pull request
Jan 30, 2015
MNT : removing minimum window size limit in tkAgg backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like to dynamically resize my plot windows and was having problems when starting large and going small. Problem is a min size limit that is set to 3/4 of original size. Limited testing shows no crash problems with removing the size limit altogether and going super small. As long as the window manager uses a border it won't be too small to see. But if a limit must be present, I suggest a hard coded limit rather than a percentage of original size that can limit valid resize requests.