Fix #4076. Change how result is stored in point_in_path/point_on_path. #4087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_picking(): | ||
| fig, ax = plt.subplots() | ||
| col = ax.scatter([0], [0], [1000]) | ||
| fig.savefig("/home/mdboom/test.png", dpi=fig.dpi) |
10955d7 to
095699e
Compare
…nt_on_path. Return indices as signed integers (since that's what Numpy wants).
0abf2cb to
0a5eea4
Compare
|
This is passing tests, and ready for final review. |
|
Are there likely side effects without test coverage? |
| @@ -209,7 +209,7 @@ inline void points_in_path(PointArray &points, | |||
| typedef agg::conv_contour<curve_t> contour_t; | |||
|
|
|||
| size_t i; | |||
| for (i = 0; i < result.size(); ++i) { | |||
| for (i = 0; i < points.size(); ++i) { | |||
There was a problem hiding this comment.
Looping over result seems safer without a check that they are the same size.
|
@efiring: I think this was merely broken by the C++ refactor, and the algorithm itself hasn't changed at all, so I think the opportunity for side effects is low: it's sort of binary works/doesn't work. This PR does add a basic test for this functionality that never existed before just to make sure it doesn't break again. |
efiring
added a commit
that referenced
this pull request
Feb 11, 2015
Fix #4076. Change how result is stored in point_in_path/point_on_path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return indices as signed integers (since that's what Numpy wants).