restore 'None' (a string) as a valid marker style (draw nothing) #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdboom, can you check if this is a right approach? |
|
I would also like to point out that I have noticed that margers specified by a color are getting black outlines. Was this intended? It is quite possible that the tests are not catching this because the thresholds might be too high. |
|
@leejjoon: Looks good. Just an oversight on my part. @WeatherGod: I think markers with a specified color have always had black outlines -- maybe I'm just misunderstanding: can you provide a code example? Can you open a new issue, because I'll probably close this one shortly. |
mdboom
added a commit
that referenced
this pull request
Aug 8, 2011
restore 'None' (a string) as a valid marker style (draw nothing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent refactoring of marker style, set_marker("None") stopped working, and this simple patch fixes this.
For a reference, here is a documentation of Line2D.set_marker method in v1.0.x-maint branch, which says that "None" is a valid marker style.
https://github.com/matplotlib/matplotlib/blob/v1.0.x-maint/lib/matplotlib/lines.py#L755