set fig.waiting = false when image data is received [backport to color_overhaul]
#4171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of image.onload, which only fires if the result changes
fig.waiting = false when image data is receivedfig.waiting = false when image data is received [backport to color_overhaul]
tacaswell
added a commit
that referenced
this pull request
Mar 3, 2015
MNT : set `fig.waiting = false` when image data is received
|
backported as 7295024d27c576c0889c9f8b3e1641c89717b7b4 |
|
Not sure what commit that backport is, but this actually went directly into 1.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of image.onload, which only fires if the value changes.
might close #4168, but I'm not sure this was the only issue.