Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Suggest non-existing default filename (Implement #3608) #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2015
Merged

Suggest non-existing default filename (Implement #3608) #4221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22cba75
Suggest unexisting default filename (Implement #3608)
Mar 15, 2015
4fe562c
Improve comments and variable names
Mar 15, 2015
4da2db8
Use py2.6 supported str format
Mar 15, 2015
28d9f53
Add tests for FigureCanvasBase.get_default_filename()
Mar 16, 2015
d30134f
Cleanup test dirs
Mar 16, 2015
85f472a
Modify test to close empty file as soon as it's created
Mar 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions lib/matplotlib/backend_bases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2253,9 +2253,21 @@ def get_default_filename(self):
Return a string, which includes extension, suitable for use as
a default filename.
"""
default_filename = self.get_window_title() or 'image'
default_filename = default_filename.lower().replace(' ', '_')
return default_filename + '.' + self.get_default_filetype()
default_basename = self.get_window_title() or 'image'
default_basename = default_basename.lower().replace(' ', '_')
default_filetype = self.get_default_filetype()
default_filename = default_basename + '.' + default_filetype

save_dir = os.path.expanduser(rcParams.get('savefig.directory', ''))

# ensure non-existing filename in save dir
i = 1
while os.path.isfile(os.path.join(save_dir, default_filename)):
# attach numerical count to basename
default_filename = '{0}-{1}.{2}'.format(default_basename, i, default_filetype)
i += 1

return default_filename

def switch_backends(self, FigureCanvasClass):
"""
Expand Down
45 changes: 45 additions & 0 deletions lib/matplotlib/tests/test_backend_bases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
from matplotlib.backend_bases import FigureCanvasBase
from matplotlib.backend_bases import RendererBase
from matplotlib.testing.decorators import image_comparison, cleanup

import matplotlib.pyplot as plt
import matplotlib.transforms as transforms
import matplotlib.path as path

from nose.tools import assert_equal

import numpy as np
import os
import shutil
import tempfile


def test_uses_per_path():
Expand Down Expand Up @@ -43,3 +53,38 @@ def check(master_transform, paths, all_transforms,
check(id, paths, tforms, offsets, facecolors, [])
check(id, paths, tforms, offsets, [], [])
check(id, paths, tforms, offsets, facecolors[0:1], edgecolors)


@cleanup
def test_get_default_filename():
try:
test_dir = tempfile.mkdtemp()
plt.rcParams['savefig.directory'] = test_dir
fig = plt.figure()
canvas = FigureCanvasBase(fig)
filename = canvas.get_default_filename()
assert_equal(filename, 'image.png')
finally:
shutil.rmtree(test_dir)


@cleanup
def test_get_default_filename_already_exists():
# From #3068: Suggest non-existing default filename
try:
test_dir = tempfile.mkdtemp()
plt.rcParams['savefig.directory'] = test_dir
fig = plt.figure()
canvas = FigureCanvasBase(fig)

# create 'image.png' in figure's save dir
open(os.path.join(test_dir, 'image.png'), 'w').close()

filename = canvas.get_default_filename()
assert_equal(filename, 'image-1.png')
finally:
shutil.rmtree(test_dir)

if __name__ == "__main__":
import nose
nose.runmodule(argv=['-s', '--with-doctest'], exit=False)