-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC : start to move MEP to docs #4249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have no real strong objection. I thought the wiki might be a lower barrier of entry to contributing, but maybe I'm wrong -- there hasn't been a lot of collaborative editing of MEPs anyway. |
I think the main downside of the wiki is that you can't leave line comments so discussion is only through the edits which I have a hard time following. I really like the emails/github notifications for keeping track of when things change. I am a bit less concerned about the barrier for entry as many of the people who would work on MEPs are already involved in the project. |
What would be the workflow for the the MEPs? like a normal PR? |
@fariza Yes |
I understand the need for a better comment tracking in the MEPs, but from experience, when implementing a MEP, sometimes the implementation changes along the way, so the MEP document has to be modified also. |
This way if the MEP does change it will get more attention, rather than the I expect the MEP text change PRs will go much faster than code PRs. On Thu, Mar 26, 2015 at 9:19 AM Federico Ariza [email protected]
|
I agree that we need more discussion and that outweighs my other concerns |
Moved template and MEP25. If people think this is a good idea, we can move the rest of them over from the wiki as well.
@matplotlib/developers Can this get an up or down soonish? |
Im fine with it now that we have an automatic build of the docs so that it is visible on matploblib.org |
+1 from me On Thu, Mar 26, 2015 at 10:16 AM, Jens Hedegaard Nielsen <
|
👍 from me. |
👍 I find myself agreeing with everything said here. I don't see implementation changes as an issue, one can change the MEP doc and the actual consequences to the codebase of that change in a single PR which I think makes it even easier to see what goes on and I believe will add to that collaborative editing of MEPs.
One thing, @tacaswell comparing the two pages for MEP25, the wiki and here, I see that your copy-paste buffer only captured the first half of the MEP... also what happened to the TOC? |
I think it's a good idea. In addition to including the second half of the MEP as noted in @OceanWolf's comment, I suggest running a line-splitter so that text lines have a target length of 60-70 characters. |
I think I have addressed all of these issues. Sorry for copy-paste fail. |
DOC : start to move MEP to docs
Moved template and MEP25.
If people think this is a good idea, we can move the rest of them over
from the wiki as well.