BUG: Quiver must copy U, V, C args so they can't change before draw() #4250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,6 +82,14 @@ def test_quiver_single(): | |||
|
|
|||
| ax.quiver([1], [1], [2], [2]) | |||
|
|
|||
| @cleanup | |||
There was a problem hiding this comment.
pep8 is complaining about one too few new lines here.
tacaswell
added a commit
that referenced
this pull request
Mar 21, 2015
BUG : Quiver must copy U, V, C args so they can't change before draw()
|
@efiring Is this worth back-porting to the color-overhaul branch? |
|
Yes, I think it is worth backporting. I've never been 100% sure what procedure to use for this; is it OK to simply cherry-pick the commit to the appropriate branch locally, and then push to github? Is that the way you have been doing it? |
|
That is what I have been doing on the premise that if I can merge someone elses PR to this branch it's kosher to merge it to an other branch. I'll take care of moving this one over. |
tacaswell
added a commit
that referenced
this pull request
Mar 21, 2015
BUG : Quiver must copy U, V, C args so they can't change before draw()
|
back-ported as 5852d83 |
|
Thank you. |
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Jun 24, 2021
For the same reason as Quiver in matplotlib#4250.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was revealed when a user was plotting to successive subplots inside a loop iterating through a numerical integration. U and V were references to objects that were updated inside the loop, but the figure was not drawn until the end. Therefore all panels showed the quiver of the last iteration.