Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add new feature to create scientific table (#4044 ) #4269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

KaiSong2014
Copy link

we used factory design pattern to implement the feature #4044
Here is our user example:
import matplotlib.pyplot as plt
import matplotlib.table as mtable
fig = plt.figure()
ax = fig.add_subplot(111)
l1 = [1, 2]
l2 = [3, 4]
t = ax.scitable(
colWidths=[0.4, 0.4],
cellText = [l1, l2],
loc="center",
colLoc="center",
rowLoc="center")

plt.show()

@tacaswell tacaswell added this to the next point release milestone Mar 23, 2015
if len(bottom) != nbars:
raise ValueError("incompatible sizes: argument 'bottom' "
"must be length %d or scalar" % nbars)
# FIXME: convert the following to proper input validation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these changes.

@tacaswell
Copy link
Member

There are a great many changes in here that should not be (all of the re-additions of asserts, everything touching scatter).

I suggest you create a new branch (not 'master') and put your changes on that branch an open a new PR against matplotlib master from your feature branch.

I am going to close this PR due to git-related issues (being from your master and the extraneous code changes). Please see http://matplotlib.org/devel/gitwash/development_workflow.html.

Also see #4245 and #4259

@@ -454,113 +455,226 @@ def get_celld(self):
return self._cells


def table(ax,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an API break, please restore this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants