Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Sets additional default values for axes and grid. #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2015
Merged

Sets additional default values for axes and grid. #4350

merged 1 commit into from
May 8, 2015

Conversation

tamasgal
Copy link
Contributor

Changes default axes edge colour to black and disables the axes grid. These settings are often set via matplotlibrc and should be overwritten by the xkcd style.

Changes default axes edge colour to black and disables the axes grid. These settings are often set via matplotlibrc and should be overwritten by the xkcd style.
@OceanWolf
Copy link
Member

Not too sure about this, when I use xkcd style, I still use colors. Perhaps set it as a strict option?

Also these changes break backwards compatibility. If we do change the defaults here then we need to push this to color overhaul...

@tacaswell
Copy link
Member

@OceanWolf I don't think this is an API change as it only affects the xkcd style which is a bit of a joke feature (although, I think there is still an open challange to see who can get an xkcd-ified figure published in a peer-reviewed journal) and this just resets these values back to the 'default' default.

I am 👍 on this as xkcd is always black and white.

@tacaswell tacaswell added this to the next point release milestone Apr 19, 2015
tacaswell added a commit that referenced this pull request May 8, 2015
MNT : Sets rcparams for axes and grid in plt.xkcd
@tacaswell tacaswell merged commit 3c95554 into matplotlib:master May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants