Memory leak for Cursor useblit=True on PySide/Python3 #4377
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a memory leak in PySide under Python3. When creating QImage objects from a data buffer the reference to the buffer is not released. This leads to a memory leak when moving the cursor around the window, and eventually a crash. A workaround is to manually set the reference counter to the correct value `1` after creating the QImage object. This is a temporary local variable, and no side effects are expected.
|
I've tested this on Python 3 on Windows with PySide, PyQt4 and PyQt5 and on MacOSX PyQt5 and there is no evidence of memory leakage or other errors. Should be able to test on Linux this evening. Travis is failing on PEP8 I'll take a look at that. |
|
attn @mdboom can you take a look at this? |
tacaswell
added a commit
that referenced
this pull request
May 8, 2015
FIX : memory leak for Cursor usblit=True on PySide/Python3 @tacaswell fixed up whitespace and merged locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a memory leak in PySide under Python3. When creating
QImage objects from a data buffer the reference to the buffer
is not released. This leads to a memory leak when moving the
cursor around the window, and eventually a crash.
A workaround is to manually set the reference counter to the
correct value
1after creating the QImage object. This isa temporary local variable, and no side effects are expected.
This is a fix for bug #4283