Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add sankey module #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

add sankey module #459

wants to merge 2 commits into from

Conversation

jdh2358
Copy link
Collaborator

@jdh2358 jdh2358 commented Sep 7, 2011

Kevin Davies has extended Yannick Copin's original sankey example into a module and provided lots of new impressive examples. Both authors have agreed to license this under BSD, and I've added a module and replaced the sankey example code with Kevin's updated demos using the sankey module.

@efiring
Copy link
Member

efiring commented Sep 12, 2011

This would be good functionality to have, but there are some style idiosyncracies: extensive use of backslash continuations, sometimes with some odd indentation, and consistent use of the assert statement for checking inputs. Maybe the thing to do is to go ahead and merge it, with the addition of a TODO comment flagging the desirability of changing the style.

@efiring
Copy link
Member

efiring commented Sep 12, 2011

I think the second commit, merging master into the topic branch, is not a good idea--it will lead to a confusing history, will it not?

@jdh2358
Copy link
Collaborator Author

jdh2358 commented Sep 12, 2011

Hmm, I have no idea how that merge happened but clearly it is a bad idea. I am going to close this pull request and reopen a new one. On the style issues, I've asked Kevin to get started with github and mpl development workflow and he is working his way through it but is a first time user. So he will be happy to contribute some cleanup but I agree we can merge in the (fixed) pull request and let him clean from master.

@jdh2358 jdh2358 closed this Sep 12, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants