cbook._putmask added to handle putmask deprecation in numpy > 1.6.x #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
putmask is deprecated in favor of the new and more powerful copyto.
|
The code looks fine. Why not call it cbook.putmask without the underscore? |
|
On 09/19/2011 05:36 AM, Jouni K. Seppänen wrote:
|
jkseppan
added a commit
that referenced
this pull request
Sep 20, 2011
cbook._putmask added to handle putmask deprecation in numpy > 1.6.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
putmask is deprecated in favor of the new and more powerful copyto.
I decided to make a compatibility version of putmask using copyto instead of the reverse because that easily yields an exact equivalence, whereas simulating a full copyto with numpy <=1.6.x would be more difficult. In the present scheme, cbook._putmask is an exact substitute for np.putmask that uses copyto internally when available, thereby suppressing the deprecation warning from numpy.