BUG: Fix ordering in radar chart example. #4804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would make the whole thing a list of key/values tuples or use an OrderedDict. Putting the order into the key like feels like it is defeating the value of using a dictionary (easy look up by key). |
Since dict keys are not guaranteed to be sorted, the various subplots would get each case at random.
4ffb9d3 to
eff6561
Compare
|
You know, I'm sure I had a reason for not making it a Anyway, I just made it a |
tacaswell
added a commit
that referenced
this pull request
Jul 29, 2015
DOC: Fix ordering in radar chart example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since dict keys are not guaranteed to be sorted, the various subplots would get each case at random.
Just a small fix for consistency.