use numpy.finfo instead of numpy.MachAr for speedup #4828
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy.MachAr is expensive to use just to determine min/max float value; use numpy.finfo instead since it caches this information. This results in significant performance gains when updating axes limits frequently.
|
#4813 is definitely related to this (it just caches the result of MachAr itself). Not sure if one approach is preferable over the other... |
|
Ah I missed that pull request. Yeah that way is probably slightly faster since it avoids creating a temporary object... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy.MachAr() is expensive to use just to determine
min/max float value; use numpy.finfo() instead since
it caches this information. This results in
significant performance gains when updating axes limits
frequently.