mep12 changes to axes_props.py #4831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ticklabels = ax.get_xticklabels() | ||
| ticklabels.extend( ax.get_yticklabels() ) | ||
| ticklabels.extend(ax.get_yticklabels()) |
There was a problem hiding this comment.
Could we make these calls cleaner by just concatenating the x and y lists together? Something like ticklines = ax.get_xticklines() + ax.get_yticklines()?
There was a problem hiding this comment.
sure, I'll give that a shot.
|
much better! Not exactly sure if it falls under MEP12, but many of these old examples haven't been updated in a long time to take advantage of newer APIs. Clear examples make for better documentation, so I am not against small modifications here and there to improve these scripts. |
WeatherGod
added a commit
that referenced
this pull request
Jul 31, 2015
mep12 changes to axes_props.py
|
Okie dokes, no problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.