Document mpl_toolkits.axes_grid1.anchored_artists #4874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,43 +1,152 @@ | |||
| from __future__ import (absolute_import, division, print_function, | |||
| unicode_literals) | |||
|
|
|||
| from matplotlib.externals import six | |||
There was a problem hiding this comment.
please leave the six import even if it isn't used to keep our files consistent.
|
I think this is ready to merge once you address @tacaswell's minor comment. |
|
merged #4864 cycled open/close to re-trigger travis on new master |
Remove non-library (and unusable) code Remove unused imports Fixed pylint issues with indentation
Add explicit setting of __all__ to prevent similiar errors
63c4e92 to
aeb2a2e
Compare
1802aa4 to
34d1937
Compare
|
I've rebased, readded the I did have to change one of the examples which imported |
|
|
||
| if __name__ == "__main__": | ||
|
|
||
| import matplotlib.pyplot as plt |
There was a problem hiding this comment.
Is it worth moving this code to an example?
jenshnielsen
added a commit
that referenced
this pull request
Dec 26, 2015
Document mpl_toolkits.axes_grid1.anchored_artists
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Oct 16, 2016
Document mpl_toolkits.axes_grid1.anchored_artists Conflicts: lib/mpl_toolkits/axes_grid1/anchored_artists.py Note that the removed imports were restored for this backport so as to not break the API for 2.0. Whether they really should be moved or not is a matter for a different PR.
Merged
|
Backported to v2.x via ef06f5f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's another PR following up on #4864.
The documentation isn't built with this commit, but I'll
push another commit (or open another PR if this is already merged) to add the API docs
to doc/mpl_toolkits/axes_grid/api/index.rst once PR #4864 is merged.