Agg restore_region is broken #4913
Conversation
| # The incoming data is float, but the _renderer type-checking wants | ||
| # to see integers. | ||
| self._renderer.restore_region(region, int(x1), int(y1), | ||
| int(x2), int(y2), int(ox), int(oy)) |
There was a problem hiding this comment.
To be pedantic, not all of the incoming data is coming in as floats. For example, region.get_extents() will return integers, which is probably why we didn't notice this bug as I think that is the typical code-path. I haven't checked what bbox.extents would return, but certainly input-sanitation should be done anyway due to the possibility of the user passing in a tuple of floats as a bbox.
How did you trigger the error?
|
Seems fine, I am also curious how you triggered this. I assume this is fall out from the change of using CXX for wrapping agg to doing it directly with the c-api. |
FIX: cast to int in input to Agg restore_region Can get floats as input, cast to int
|
Merging this as it restores previous behavior of implicit cast to int. If we want to intentionally break that we should have that discussion later. |
The original version used to have float parameters that would be converted to integers in the agg renderer C++ file. The current version now performs some type-checking in the Python->C++ layer that will throw an exception tot he float values that are passed in. This fix makes sure that we are indeed passing in integers to the C++ method.
This addresses an issue in #4897.