-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
MNT: changed close button color and text #4924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Changed color from red (btn-danger) to blue (btn-primary) - Changed mouse-over text from 'Close Figure' -> 'Stop Interaction' - Changed icon from times -> stop
Disclosure: @doraf is my fiancée and a professional web developer/designer. |
Some comments (which has been mentioned before elsewhere by others). I think the bar used for the figure is much too thick, and the toolbar buttons are just a tad too small. So it would be nice to see that adjusted as well. I think moving away from red is a good idea, and blue makes a lot of sense. But the square icon doesn't really mean anything to me. It kinda looks like a misplaced bullet point. |
It is going for 'stop' like in media players because what it is doing is This was driven by those comments, but i got distracted along the way. On Sat, Aug 15, 2015, 9:13 AM Benjamin Root [email protected]
|
Hmm, I agree that it shouldn't be an X, because, as you say, it doesn't On Sat, Aug 15, 2015 at 3:08 PM, Thomas A Caswell [email protected]
|
In a way what the button is doing is freezing the plot. Is there a
suitable icon for that? An iceberg?
|
The FA icons are here https://fortawesome.github.io/Font-Awesome/icons/ I didn't find a better one on the first pass |
Perhaps power off? http://fortawesome.github.io/Font-Awesome/icon/power-off/ |
We also have access to the Twitter bootstrap glyphs, but i am not sure if On Sat, Aug 15, 2015, 3:55 PM Jens Hedegaard Nielsen <
|
Another concerted suggestion was to move the stop button down into the tool I like power off as the icon. On Sat, Aug 15, 2015, 3:57 PM Jens Hedegaard Nielsen <
|
Change from 'fa-stop' -> 'fa-poweroff'
I like these changes. I would also like to se a smaller top bar or perhaps remove and more the button down? but perhaps that is for another PR? |
Nice improvement. Thanks @tacaswell and @doraf - can't believe he's dragged you into mpl, but you're very welcome 😄 I would definitely like to reduce the bar size - it is a bit too prominent IMHO. As has already been mentioned, maybe we can get rid of it altogether, and put the power off icon in the toolbar. We could then put a newline above the icons, and use that for title, and potentially a slightly wider tooltip area (for those long coordinate values)... |
MNT: changed close button color and text
Thoughts?
attn @pelson @doraf