Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MNT: changed close button color and text #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2015

Conversation

tacaswell
Copy link
Member

  • Changed color from red (btn-danger) to blue (btn-primary)
  • Changed mouse-over text from 'Close Figure' -> 'Stop Interaction'
  • Changed icon from times -> stop

so

Thoughts?

attn @pelson @doraf

 - Changed color from red (btn-danger) to blue (btn-primary)
 - Changed mouse-over text from 'Close Figure' -> 'Stop Interaction'
 - Changed icon from times -> stop
@tacaswell
Copy link
Member Author

Disclosure: @doraf is my fiancée and a professional web developer/designer.

@WeatherGod
Copy link
Member

Some comments (which has been mentioned before elsewhere by others). I think the bar used for the figure is much too thick, and the toolbar buttons are just a tad too small. So it would be nice to see that adjusted as well.

I think moving away from red is a good idea, and blue makes a lot of sense. But the square icon doesn't really mean anything to me. It kinda looks like a misplaced bullet point.

@tacaswell
Copy link
Member Author

It is going for 'stop' like in media players because what it is doing is
stopping the interaction, but it leaves a static png in its place.

This was driven by those comments, but i got distracted along the way.

On Sat, Aug 15, 2015, 9:13 AM Benjamin Root [email protected]
wrote:

Some comments (which has been mentioned before elsewhere by others). I
think the bar used for the figure is much too thick, and the toolbar
buttons are just a tad too small. So it would be nice to see that adjusted
as well.

I think moving away from red is a good idea, and blue makes a lot of
sense. But the square icon doesn't really mean anything to me. It kinda
looks like a misplaced bullet point.


Reply to this email directly or view it on GitHub
#4924 (comment)
.

@WeatherGod
Copy link
Member

Hmm, I agree that it shouldn't be an X, because, as you say, it doesn't
close the figure, it just stops the interaction. But I didn't see it as a
stop button, though. I don't know why.

On Sat, Aug 15, 2015 at 3:08 PM, Thomas A Caswell [email protected]
wrote:

It is going for 'stop' like in media players because what it is doing is
stopping the interaction, but it leaves a static png in its place.

This was driven by those comments, but i got distracted along the way.

On Sat, Aug 15, 2015, 9:13 AM Benjamin Root [email protected]
wrote:

Some comments (which has been mentioned before elsewhere by others). I
think the bar used for the figure is much too thick, and the toolbar
buttons are just a tad too small. So it would be nice to see that
adjusted
as well.

I think moving away from red is a good idea, and blue makes a lot of
sense. But the square icon doesn't really mean anything to me. It kinda
looks like a misplaced bullet point.


Reply to this email directly or view it on GitHub
<
https://github.com/matplotlib/matplotlib/pull/4924#issuecomment-131369880>
.


Reply to this email directly or view it on GitHub
#4924 (comment)
.

@efiring
Copy link
Member

efiring commented Aug 15, 2015 via email

@jenshnielsen
Copy link
Member

The FA icons are here https://fortawesome.github.io/Font-Awesome/icons/

I didn't find a better one on the first pass

@jenshnielsen
Copy link
Member

@tacaswell
Copy link
Member Author

We also have access to the Twitter bootstrap glyphs, but i am not sure if
that is going to be used in the future IPython

On Sat, Aug 15, 2015, 3:55 PM Jens Hedegaard Nielsen <
[email protected]> wrote:

The FA icons are here https://fortawesome.github.io/Font-Awesome/icons/

I didn't find a better one on the first pass


Reply to this email directly or view it on GitHub
#4924 (comment)
.

@tacaswell
Copy link
Member Author

Another concerted suggestion was to move the stop button down into the tool
bar. We would then have to sort out where to put the future number label.

I like power off as the icon.

On Sat, Aug 15, 2015, 3:57 PM Jens Hedegaard Nielsen <
[email protected]> wrote:

Perhaps power off?
http://fortawesome.github.io/Font-Awesome/icon/power-off/


Reply to this email directly or view it on GitHub
#4924 (comment)
.

Change from 'fa-stop' -> 'fa-poweroff'
@jenshnielsen
Copy link
Member

I like these changes. I would also like to se a smaller top bar or perhaps remove and more the button down? but perhaps that is for another PR?

@pelson
Copy link
Member

pelson commented Aug 27, 2015

Nice improvement. Thanks @tacaswell and @doraf - can't believe he's dragged you into mpl, but you're very welcome 😄

I would definitely like to reduce the bar size - it is a bit too prominent IMHO.

As has already been mentioned, maybe we can get rid of it altogether, and put the power off icon in the toolbar. We could then put a newline above the icons, and use that for title, and potentially a slightly wider tooltip area (for those long coordinate values)...

pelson added a commit that referenced this pull request Aug 27, 2015
MNT: changed close button color and text
@pelson pelson merged commit a81b8fc into matplotlib:master Aug 27, 2015
@tacaswell tacaswell deleted the change_nbagg_styling branch August 27, 2015 12:32
@tacaswell tacaswell modified the milestones: Color overhaul, next major release (2.0) Oct 26, 2015
@QuLogic QuLogic modified the milestones: v1.5.0, 2.0 (style change major release) Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants