Thanks to visit codestin.com
Credit goes to github.com

Skip to content

mep12 on geo_demo.py #5030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2015
Merged

mep12 on geo_demo.py #5030

merged 1 commit into from
Sep 4, 2015

Conversation

ericmjl
Copy link
Contributor

@ericmjl ericmjl commented Sep 4, 2015

No description provided.

@ericmjl
Copy link
Contributor Author

ericmjl commented Sep 4, 2015

Looks like that worked.

@WeatherGod WeatherGod added the MEP: MEP12 gallery and examples improvements label Sep 4, 2015
WeatherGod added a commit that referenced this pull request Sep 4, 2015
@WeatherGod WeatherGod merged commit 0bbf040 into matplotlib:master Sep 4, 2015
@WeatherGod
Copy link
Member

Indeed!

@twmr
Copy link
Contributor

twmr commented Sep 4, 2015

How many pylab examples do you still need to convert? IMHO it would be faster (and also energy-saving as the # of travis CI runs gets reduced), if you grouped several examples into a single PR, but this has probably already been discussed in one of your PRs.

@ericmjl
Copy link
Contributor Author

ericmjl commented Sep 4, 2015

Not many examples left before having to reclassify them. I estimate ~15-ish right now. I decided against multiple examples in a single PR earlier. Forgot the exact reason, but I think it had to do with simplifying each PR.

@ericmjl ericmjl deleted the mep12_geo_demo.py branch September 4, 2015 19:33
@WeatherGod
Copy link
Member

I'd be happy with 3 examples per PR. Especially now that it seems like you
are getting the hang of git and such.

By the way, in case it hasn't been said, we are really grateful for this
work that you are doing. It goes a long way to improving our
documentation!

On Fri, Sep 4, 2015 at 3:33 PM, Eric Ma [email protected] wrote:

Not many examples left before having to reclassify them. I estimate
~15-ish right now. I decided against multiple examples in a single PR
earlier. Forgot the exact reason, but I think it had to do with simplifying
each PR.


Reply to this email directly or view it on GitHub
#5030 (comment)
.

@ericmjl
Copy link
Contributor Author

ericmjl commented Sep 5, 2015

Thanks a lot guys! 😄 I'm happy to help as well!

Btw, some nice things I've observed so far about this - The task's level was just right for my level, it gave me the extra knowledge to make my own repos continuously-integrated, and oh my, it was a great release/positive distraction to work on open source having had my paper rejected from a 3rd journal 😆

@tacaswell
Copy link
Member

@ericmjl Seconding what Ben says, thank you so much for doing this! Poor documentation and out of date examples are the soft dark underbelly of OSS.

Also glad to hear that this work has made you a better developer in your other work. That has been my experience as well and is one of (in my view) the best things about our community.

@QuLogic QuLogic added this to the v1.5.0 milestone Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MEP: MEP12 gallery and examples improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants