qt imports fix #5134
Merged
qt imports fix #5134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an error where PyQt4 would always be selected in the case where a Qt related file was imported, but not set as the current backend Change from jrevans commit : Check what PyQt version is actually used rather than try to force the use of PyQt5.
|
@jrevans Does this fix your problems? |
| # A different backend was specified, but we still got here because a Qt | ||
| # related file was imported. This is allowed, so lets try and guess | ||
| # what we should be using. | ||
| if "PyQt5" in sys.modules: |
There was a problem hiding this comment.
Can you invert this logic to check for pyqt4 and default to 5?
There was a problem hiding this comment.
PyQt5 is default, now.
Pyqt5 by default.
Fix comment
| # A different backend was specified, but we still got here because a Qt | ||
| # related file was imported. This is allowed, so lets try and guess | ||
| # what we should be using. | ||
| if "PyQt4" in sys.modules: |
There was a problem hiding this comment.
This also needs to check for PySide, sorry I did not realize that before.
There was a problem hiding this comment.
For the PyQt4 lines ?
I never used PySide. So, don't know its specificities.
Is the following change correct ?
if "PyQt4" in sys.modules:=>
if "PyQt4" in sys.modules or "PySide" in sys.modules:Add PySide
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this pull request :
#4912