Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cleaned up text in pyplot_tutorial.rst #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 4, 2015
Merged

Cleaned up text in pyplot_tutorial.rst #5147

merged 4 commits into from
Oct 4, 2015

Conversation

gcallah
Copy link
Contributor

@gcallah gcallah commented Sep 26, 2015

Only minor changes to grammar, etc.

tacaswell
tacaswell reviewed Sep 26, 2015
View reviewed changes
doc/users/pyplot_tutorial.rst
keeps track of the current figure and plotting area, and the plotting
some change to a figure: e.g., creates a figure, creates a plotting area
in a figure, plots some lines in a plotting area, decorates the plot
with labels, etc. In :mod:`matplotlib.pyplot` various states are preserved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be a bit more explicit about what state is tracked which is only the current figure and axes (there is also a gci, but it should not be used).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the saved current image is used by set_cmap, clim, and colorbar, so it is an important part of the state.

@gcallah
Copy link
Contributor Author

gcallah commented Oct 1, 2015

I have updated the document per these remarks, except: Eric, should I add the current saved image to the list of state info kept by the function-call API?

@efiring
Copy link
Member

efiring commented Oct 1, 2015

On 2015/09/30 4:19 PM, Gene Callahan wrote:

I have updated the document per these remarks, except: Eric, should I
add the current saved image to the list of state info kept by the
function-call API?

I would say that if you list current figure and axes, then you should
also list current image. (Internally, the current image is tracked on a
per-figure basis by the Figure instance. The reason this is needed in
addition to the current axes is that one might create 3 subplots, put an
image-like Artist in each of the first two and a line plot in the third.
The current axes would then be the last subplot, but the current image
would be in the middle subplot.)

@gcallah
Copy link
Contributor Author

gcallah commented Oct 1, 2015

Ok, added.

tacaswell added a commit that referenced this pull request Oct 4, 2015
@tacaswell
Merge pull request #5147 from gcallah/master
dcc3a42 
DOC: Cleaned up text in pyplot_tutorial.rst
@tacaswell tacaswell merged commit dcc3a42 into matplotlib:master Oct 4, 2015
tacaswell added a commit that referenced this pull request Oct 4, 2015
@tacaswell
Merge pull request #5147 from gcallah/master
fc27a8e 
DOC: Cleaned up text in pyplot_tutorial.rst
@QuLogic QuLogic added this to the proposed next point release (2.1) milestone Oct 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@gcallah @efiring @tacaswell @QuLogic