-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
FIX: remove incorrect error checking #5187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently fails with qt5
this indeed fix teh errors with the unittest raising that exception, but now that it passes, other errors came out:
|
That looks like there is a cross between qt4 vs qt5 ... |
FIX: remove incorrect error checking
I can reproduce that issue with both qt 4 and 5 installed. It looks like something has gotten crossed in the refactoring. |
@jenshnielsen What backend is this with? |
That was the qt4 tests in the test suite |
@jenshnielsen Took me a while, but I got there. |
Currently fails with qt5