Merge v1.1.x #538
Merged
Merge v1.1.x #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in Firefox. Closes matplotlib#510.
…t_size_bug Backend svg firefox font size bug
Reorder ttconv
Figure animated2
|
Looks good to me. As a policy question, do we generally want to submit pull requests for these kinds of merges, or just do them? |
|
i've also been puzzled by trying to figure out why we might possibly not want to merge these changes - as @mdboom mentions, I'd be in favor of just pushing changes like these to the the master branch without a PR |
|
I have no problem just merging these going forward. I had a few hiccups getting my git/github sea legs under me, and submitted a couple of pull requests which were not correct, so I wanted to get some eyeballs on these to make sure I was doing them right. Going forward, I think I can just merge and push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge bugfixes from v1.1.x