Fix for broken maplotlib.test function #5537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we gather the plugins, we go through two list comprehensions, but call them each time. So on the second pass, the plugins that were called the first time can't be called again. This change makes it so that all fo the plugins are called together in the second list comprehension.
| @@ -1550,7 +1550,7 @@ def test(verbosity=1, coverage=False): | |||
|
|
|||
| # store the old values before overriding | |||
| plugins = _get_extra_test_plugins() | |||
| plugins.extend([plugin() for plugin in nose.plugins.builtin.plugins]) | |||
| plugins.extend([plugin for plugin in nose.plugins.builtin.plugins]) | |||
|
|
|||
| manager = PluginManager(plugins=[x() for x in plugins]) | |||
There was a problem hiding this comment.
we only need to call the plugins here.
tacaswell
added a commit
that referenced
this pull request
Nov 21, 2015
FIX: for broken maplotlib.test function
|
Should be in 1.5.x as well? |
|
It does not back port cleanly. I have not checked, but i think this is On Sat, Nov 21, 2015, 18:38 Elliott Sales de Andrade <
|
|
Oh right, I may have confused this one with #5487. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So if I try to run
import matplotlib; matplotlib.test(), I get this error:This was b/c we call some plugins in a list comprehension twice (https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/__init__.py#L1551)