Fix span stay blit #5681
Merged
Fix span stay blit #5681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rect properties for the 'live' rect were being forwarded re-used for the stay artist, however if blitting is used, then 'animated' is set which exclude the artist from the normal draw tree.
Force a full re-draw on the last span is not in the blit background
|
Works for me. |
| @@ -1473,6 +1473,7 @@ def new_axes(self, ax): | |||
| transform=trans, | |||
| visible=False, | |||
| **self.rectprops) | |||
| self.stay_rect.set_animated(False) | |||
There was a problem hiding this comment.
Trying to make sure I understand this bug (and make sure this is the right fix). Essentially, self.rectprops is going to have an "animated" entry that will be set to True when blitting is turned on. This, I think, is the essential bug that gets fixed in this line, because a static rectangle object isn't ever intended to be animated. So this part I am good with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.