Fix twin remove #5682
Merged
Fix twin remove #5682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also add tests
This test touches the internals, if Grouper gets refactored this test should be removed.
This adds clean up of the shared axes `Grouper` objects as part of removing an axes. `_reset_loc_form` is required because the locator/formatters end up bound to the axis objects of the last axes object (all of the Axes in the group share the same formatter/locator objects but have different Axis objects so that all but one of the Axis objects can be made not visible to not over-draw). If these are not re-bound to a still visible axes then changing the limits will change the view limits, but not the tick locations. closes matplotlib#5663
|
Restarted Python 3.3 on Travis (which looks unrelated). 👍 on merging once passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adds tests to
cbook.GrouperThis addresses half of #1312 use case by providing a clean way to remove shared axes.