FIX: suppress warning in Artist.properties #5710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `get_axes` currently raises a deprecating warning, eat this. The Artist.properties function will be completely re-written in 2.1 with traitlets so this is a reasonable stop-gap for now. closes matplotlib#5089
| @@ -1276,7 +1276,9 @@ def properties(self): | |||
| continue | |||
|
|
|||
| try: | |||
| val = func() | |||
| with warnings.catch_warnings(): | |||
| warnings.simplefilter('ignore') | |||
There was a problem hiding this comment.
shouldn't the catch_warnings() be sufficient?
There was a problem hiding this comment.
Followed the directions here
https://docs.python.org/3/library/warnings.html#temporarily-suppressing-warnings
There was a problem hiding this comment.
@tacaswell is right. I had to add a similar change in jenshnielsen@0e1be8e to silence a warning in the cycler code
jenshnielsen
added a commit
that referenced
this pull request
Dec 26, 2015
FIX: suppress warning in Artist.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
get_axescurrently raises a deprecating warning, eat this.The Artist.properties function will be completely re-written in 2.1 with
traitlets so this is a reasonable stop-gap for now.
closes #5089