-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix floating point inaccuracies in axes limits; partial work on offset value selection #5768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
-67 Bytes
(97%)
lib/matplotlib/tests/baseline_images/test_axes/autoscale_tiny_range.pdf
Binary file not shown.
Binary file modified
BIN
+164 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/autoscale_tiny_range.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
436 changes: 194 additions & 242 deletions
436
lib/matplotlib/tests/baseline_images/test_axes/autoscale_tiny_range.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-104 Bytes
(99%)
lib/matplotlib/tests/baseline_images/test_axes/bar_tick_label_single.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+5 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/errorbar_mixed.pdf
Binary file not shown.
1,012 changes: 506 additions & 506 deletions
1,012
lib/matplotlib/tests/baseline_images/test_axes/errorbar_mixed.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-27 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/formatter_large_small.pdf
Binary file not shown.
Binary file modified
BIN
-92 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/formatter_large_small.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
234 changes: 107 additions & 127 deletions
234
lib/matplotlib/tests/baseline_images/test_axes/formatter_large_small.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.19 KB
(72%)
lib/matplotlib/tests/baseline_images/test_axes/twin_spines_on_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+886 Bytes
(110%)
lib/matplotlib/tests/baseline_images/test_bbox_tight/bbox_inches_tight_raster.pdf
Binary file not shown.
Binary file modified
BIN
+193 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_bbox_tight/bbox_inches_tight_raster.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
72 changes: 30 additions & 42 deletions
72
lib/matplotlib/tests/baseline_images/test_bbox_tight/bbox_inches_tight_raster.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+30 Bytes
(100%)
lib/mpl_toolkits/tests/baseline_images/test_mplot3d/quiver3d.pdf
Binary file not shown.
Binary file modified
BIN
+424 Bytes
(100%)
lib/mpl_toolkits/tests/baseline_images/test_mplot3d/quiver3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to go through a deprecation cycle for
bin_boundaries
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. Can we avoid that simply by renaming _raw_ticks back to bin_boundaries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, we have been saying for a while we want to reduce the size of the public API and this is part of the internal details of how the MaxN locator works so it should be private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note tha the behavior of
_raw_ticks
is slightly different frombin_boundaries
(namely it handles properly floating-point inaccuracies), so given that strict backwards compatibility has been broken I think it's a good opportunity to make it private. If you prefer I can leave the (now unused) old implementation ofbin_boundaries
in, with a deprecation warning.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bug fix (handling floating point better) would not in itself require a name change or deprecation, but I'm perfectly happy with the new private name. To be on the safe side, a deprecation cycle of the old name would be a good idea. (I thought it was being used elsewhere, but I haven't found any such instances.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored
bin_boundaries
with a deprecation warning since v2.0.