Include test_text in default_test_modules #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see any reason to have tests in the tree that do not get run. Please merge this. |
|
I'll go ahead and merge this -- on the v1.0.x branch. However, I'm not able to reproduce the failure in test_text:test_font_styles. I'll go ahead and create an issue for that, and maybe Paul can provide more info, pictures etc. over there. |
Closed
magnunor
pushed a commit
to magnunor/matplotlib
that referenced
this pull request
Dec 5, 2013
…ritten in the add_elements method. Bug reported by Magnus Nord in issue matplotlib#58
fariza
added a commit
to fariza/matplotlib
that referenced
this pull request
Sep 22, 2016
Adding logo image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a pull request for this two line change just in case there was a specific reason to exclude test_text from the test modules.
For instance, right now, I get one failure in the test suite if I include it. The failure is in test_text:test_font_styles, but this has been the case for a while, it's just that these tests weren't running before.
Any developers want to chime in on this?
By the way, this was the source of discrepancy between running via nosetests and matplotlib.test() as was described [here] [1]
[1]: http://old.nabble.com/matplotlib.test%28%29-no-errors%2C-but-%24nosetest-matplotlib.tests--%3E-errors-%09and-failure--td29257062.html#a29257062 "here".