Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix sliders #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix sliders #581

wants to merge 2 commits into from

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Nov 10, 2011

Alternative to #576 that should have fewer side effects since it doesn't circumvent the Polygon.set_closed method. axhspan and axvspan should have been declared closed all along.

@mdboom
Alternative to matplotlib#576 that should have fewer side effects sin…
71e4105 
…ce it doesn't circumvent the Polygon.set_closed method. axhspan and axvspan should have been declared closed all along.
@mdboom mdboom mentioned this pull request Nov 10, 2011
Merged
@mdboom
Copy link
Member Author

mdboom commented Nov 16, 2011

Ok. I think the next thing to do is decide whether this or #576 makes more sense.

@cgohlke
Copy link
Contributor

cgohlke commented Nov 16, 2011

While this fixes the slider demo, #576 addresses two more issues:

  1. When a Slider is initialized with valmin == valinit, the indicator is a triangle (e.g. set a0 = 0.1 in slider_demo.py)
  2. It might not be safe to call set_closed(False) repeatedly, e.g. on a Polygon where all vertices have the same coordinates.

@mdboom mdboom closed this Dec 14, 2011
@mdboom mdboom deleted the sliders branch November 10, 2015 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdboom @cgohlke