Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enh local freetype tweaks #5874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2016
Merged

Enh local freetype tweaks #5874

merged 4 commits into from
Feb 9, 2016

Conversation

tacaswell
Copy link
Member

Makes my workflow (git clean -xfd python setup.py develop python tests.py) by letting you enable local freetype by setting an env and by caching the freetype tarball outside of the build tree.

This should also (marginally) speed up travis by not having to re-download the freetype tarball every time and not having to re-build the font cache.

@tacaswell
MNT: use getboolean on config
c878912 
Parse 'true'/'false', 'on'/'off', 1/0 to bool
@tacaswell
ENH: use env MPLLOCALFREETYPE for local freetype
5ad9b15 
'or' the env value (defaults to False) with the value from setup.cfg
@tacaswell
TST/BLD: add caching logic for local freetype
e1dc44f 
This will only work in python 3

 - add caching logic
 - add .cache/matplotlib to travis cache.  This should also save us time
   on font cache re-generation.
@tacaswell
TST: remove folders we do not want to cache
dd559db 
We do not want to cache tex.cache (which hold the output of latex from
text rendering) or test_cache (which holds output from converting
svg/pdf to png for image comparisons) between runs of the test suite.
@tacaswell tacaswell added this to the next major release (2.0) milestone Jan 18, 2016
@mdboom
Copy link
Member

mdboom commented Jan 18, 2016

👍 I had been meaning to do this myself, but hadn't found the time.

@mdboom
Copy link
Member

mdboom commented Jan 18, 2016

No issues with this as-is -- but maybe we want to move to using the env var on Travis? Right now it copies a file for setup.cfg -- we could get rid of that and the setup.cfg file template file itself by using the env variable. (And consider whether in the interest of OOWTDI we should only do env variable... this feature hasn't been around long enough or used by a broad enough community that we need to worry too much about backward compat).

@tacaswell
Copy link
Member Author

On the other hand, using setup.cfg seems to be the 'standard' way to control configure setup.py so that should be the one way to do things and the env is a convenience method. I don't think we want to put people in the situation where they need to control somethings only via setup.cfg and somethings only via env.

@mdboom
Copy link
Member

mdboom commented Jan 18, 2016

Fair enough. The env var is required to pip install matplotlib in local-freetype mode, though, so I guess we need both. No big deal at the end of the day.

@tacaswell
Copy link
Member Author

Have now seen intermittent travis failures due to dling freetype timing out. This PR would prevent that by keeping a cache of it.

mdboom added a commit that referenced this pull request Feb 9, 2016
@mdboom
Merge pull request #5874 from tacaswell/enh_local_freetype_tweaks
ea61ca5 
Enh local freetype tweaks
@mdboom mdboom merged commit ea61ca5 into matplotlib:v2.x Feb 9, 2016
@tacaswell tacaswell deleted the enh_local_freetype_tweaks branch February 10, 2016 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tacaswell @mdboom