FIX: do not short-cut all white-space strings #6005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When drawing text, assume that all user input is valid input and do not consider an all white space string to be equivalent to an empty string. Closes matplotlib#2698
|
Odd test failure, only on 2.7: ImageComparisonFailure: images not close: /home/travis/build/matplotlib/matplotlib/result_images/test_collections/EventCollection_plot__set_lineoffset_svg.png vs. /home/travis/build/matplotlib/matplotlib/result_images/test_collections/EventCollection_plot__set_lineoffset-expected_svg.png (RMS 0.080) |
|
@efiring I could not reproduce locally and restarting the test seems to have fixed it. |
efiring
added a commit
that referenced
this pull request
Feb 17, 2016
FIX: do not short-cut all white-space strings
|
The intermittent failure happened on master again https://travis-ci.org/matplotlib/matplotlib/builds/109789572 |
|
Again, it is showing up only in svg and on 2.7. It's hard to see how it could be related to this change--or to anything else, for that matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When drawing text, assume that all user input is valid input and do not
consider an all white space string to be equivalent to an empty string.
Closes #2698