Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Patch issue #6035 #6054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Patch issue #6035 #6054

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f5fc2fa
First draft to correct issue #6035 and to write relevant unit tests. …
afvincent Feb 23, 2016
5651a23
Achieve DPI-independent arrow heads in a cleaner way
afvincent Feb 23, 2016
a529161
Add a new unit test to check that a raw FancyArrowPatch is DPI-indepe…
afvincent Feb 23, 2016
38e345a
Docstring fix
afvincent Feb 23, 2016
0955cf9
Removed whitespaces (for PEP8)
afvincent Feb 23, 2016
74eff0b
Added 2nd whitespace before inline comment (PEP8)
afvincent Feb 23, 2016
903348a
Should fix broken unit tests 'polar_axes' and 'polar_coords' in test_…
Feb 25, 2016
6d2399f
Docstring/comments fixes & PEP8.
afvincent Mar 29, 2016
a552429
Docstring fix
afvincent Apr 1, 2016
385917d
Update of failing PNGs in test_axes
afvincent Apr 1, 2016
c9faebe
New rebase and update of wrong PNG baseline images
afvincent May 14, 2016
683214b
Update w/ PNGs produced on a computer (that should be) w/o fonts issue
afvincent May 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Should fix broken unit tests 'polar_axes' and 'polar_coords' in test_… 
…axes
  • Loading branch information
@afvincent
Adrien VINCENT authored and afvincent committed May 14, 2016
commit 903348ab04143b452fdccac76f5634cecf3f08c7
16 changes: 11 additions & 5 deletions lib/matplotlib/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2163,11 +2163,17 @@ def _update_position_xytext(self, renderer, xy_pixel):
" use 'headlength' to set the head length in points.")
headlength = d.pop('headlength', 12)

to_style = self.figure.dpi / (72 * ms)

stylekw = dict(head_length=headlength * to_style,
head_width=headwidth * to_style,
tail_width=width * to_style)
# Old way:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this comment block

If anyone has to do forensics on this part of the code recursive git-blame is their friend. I think going forward the discussion of old and new way will just lead to confusion

# ms_pix = renderer.points_to_pixels(ms)
# to_style = self.figure.dpi / (72 * ms_pix)
# NB: is there a reason to use self.figure.dpi / (72 * ms_pix)
# instead of renderer.points_to_pixels(1.) / ms_pix? Both
# should be equal to '1 / ms', shouldn't they (by the way)?
#
# New way: '* to_style' <- '/ ms' (ms is now still in pts here)
stylekw = dict(head_length=headlength / ms,
head_width=headwidth / ms,
tail_width=width / ms)

self.arrow_patch.set_arrowstyle('simple', **stylekw)

Expand Down