Thanks to visit codestin.com
Credit goes to github.com

Skip to content

simplified, added comment on usetex #6107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

dacoex
Copy link
Contributor

@dacoex dacoex commented Mar 4, 2016

@tacaswell
Copy link
Member

I am slightly biased towards leaving the example as usetex=True and the comment saying 'if you do not have LaTeX installed change this to False'.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Mar 4, 2016
@dacoex
Copy link
Contributor Author

dacoex commented Mar 4, 2016

@tacaswell I can change although I cannot see what would require the use of text in that segment.

@tacaswell
Copy link
Member

Showing off that it can be done. Integration with LaTeX is a major selling point in some fields and it defaults to False to avoid these sorts of issues.

@@ -18,7 +18,8 @@
pdf.savefig() # saves the current figure into a pdf page
plt.close()

plt.rc('text', usetex=True)
plt.rc('text', usetex=True) # if LaTeX is not installed or error caught,
# change to `usetex=False` to make it work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not aligned any more; however, I think it might be simpler to just place the comment above the code (if it fits within 80 characters).

@QuLogic
Copy link
Member

QuLogic commented Mar 4, 2016

Can you please rebase and squash the commits together?

It appears that the first commit does not have your correct email address; please be sure that it is correct after rebasing.

@tacaswell
Copy link
Member

When you rebase you need to do a force-push to gh

git push --force dacoex pdfmulti_tex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants