Fix: pandas series of strings #6158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -715,6 +715,17 @@ def is_sequence_of_strings(obj): | |||
| return True | |||
|
|
|||
|
|
|||
| def is_hashable(obj): | |||
There was a problem hiding this comment.
Does isinstance(obj, collections.Hashable) not work?
There was a problem hiding this comment.
That only works for built-in types or types that explicitly use the collections.Hashable abc. This implementation is more "duck-typing" style and therefore includes more things.
There was a problem hiding this comment.
e.g. numpy/numpy#5562
84173a4 to
98a201a
Compare
*Problem* Pandas series of strings exhibits string like behaviour and it was being treated as a single string. *Solution* When requiring and identifying a single string, make sure that the object can be hashed. This screens out the series and lets them get rightly handled as sequences.
98a201a to
6ef3583
Compare
tacaswell
added a commit
that referenced
this pull request
Mar 16, 2016
Fix: pandas series of strings
|
@has2k1 Thanks! |
tacaswell
added a commit
that referenced
this pull request
Mar 17, 2016
Fix: pandas series of strings Conflicts: lib/matplotlib/collections.py Manually merged changes
|
backported to v1.5.x as c78ca18 |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
Fix: pandas series of strings Conflicts: lib/matplotlib/collections.py Manually merged changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pandas series of strings exhibits string like behaviour
and it was being treated as a single string.
Solution
When requiring and identifying a single string, make sure
that the object can be hashed. This screens out the
series and lets them get rightly handled as sequences.