Adjust test tolerance to pass for me on OSX #6249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 from me. And I'm fine with removing the windows-specific settings. |
| @@ -2763,7 +2763,7 @@ def test_subplot_key_hash(): | |||
| @image_comparison(baseline_images=['specgram_freqs', | |||
| 'specgram_freqs_linear'], | |||
| remove_text=True, extensions=['png'], | |||
| tol=0.07 if on_win else 0.03) | |||
There was a problem hiding this comment.
Can you also remove on_win and the sys import as well?
e5b6a68 to
598dce8
Compare
mdboom
added a commit
that referenced
this pull request
Apr 7, 2016
Adjust test tolerance to pass for me on OSX
|
Cherry-picked to v2.x as 9a74cd7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mainly the same as changed on windows. Rather than making more OS specific hacks I have changed them everywhere but I could be convinced otherwise.
None of the changes are related to text/freetype as far as I can see but more likely to be related to floating point math and thus libraries, OS, compilers, CPU architecture ...
Might want to backport to 2.x