FIX: cross figure legends with patches #6350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found via biocore/qiime#2117 The `update_props` method on `Patch` was setting the figure along with the style. This was setting the new patch for the legend to have the same figure as the original handle, but this is later attempted to be set to the figure the legend is in when the patch is added to the legend. This fix should not break anything as if the patch is going to be drawn it should be added to the draw tree which _should_ in turn set the correct figure.
|
Looks reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via biocore/qiime#2117
The
update_propsmethod onPatchwas setting the figure alongwith the style. This was setting the new patch for the legend to have
the same figure as the original handle, but this is later attempted to
be set to the figure the legend is in when the patch is added to the
legend.
This fix should not break anything as if the patch is going to be drawn
it should be added to the draw tree which should in turn set the
correct figure.