-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Stackplot weighted_wiggle zero-area fix #6358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you force-push just the first commit (with out the merge from master)? Can you also add an image test that exercises this condition? It might be best to modify the test data in Other wise 👍 |
Force push done. |
Will you have time to add a test for this? |
I'm trying, but I'm running on OSX in a Conda virtual environment, so having issues with that. The frameworkpython method doesn't seem to work for me, and I don't have that much time, unfortunately. Any ideas on getting my venv working? |
Just to be sure this makes sense, what I'd do is simply add d[50,:] = 0 # test for fixed weighted wiggle (issue #6313) after line 1394 in matplotlib/tests/test_axis.py. To generate the baseline image, I have this script, but that's the one that won't run in my venv, so that's where I'm stuck. |
Others might have better methods, but here is what I do to develop mpl from within a conda environment on OSX:
|
@efiring Awesome, that did the trick, thanks! Well, almost, I had to combine it with this pythonw/python.app tip. Perhaps an idea to put this method in the documentation? I assume steps 1 and 2 are to automatically install dependencies, right? Anyway, will try to generate the test images using this setup asap. |
Ok, forgot to add |
@tacaswell: matplotlib.tests.test_mlab.rec2txt_testcase is failing in AppVeyor. Does that have anything to do with stackplot / this PR? |
No, that is a separate issue. |
FIX: Stackplot weighted_wiggle zero-area
Thanks! I think this is your first contribution to the mpl source. Congratulations and hope we hear from you again. Backported to v2.x as 102872a |
See #6313.