Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add a ax.voxels(bool3d) function #6404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Aug 10, 2017
Merged

Add a ax.voxels(bool3d) function #6404

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3d0d3fa
Add a ax.voxels(bool3d) function
eric-wieser May 11, 2016
aeef04b
Return the list of added Poly3DCollections
eric-wieser May 31, 2016
508541a
Remove repeated computation
eric-wieser May 31, 2016
4690576
Be explicit about slicing
eric-wieser Jul 13, 2017
61d1ad2
Improve documentation
eric-wieser Jul 14, 2017
64ff6ae
Add what's new
eric-wieser Jul 14, 2017
25e859f
Add image comparison tests
eric-wieser Jul 14, 2017
0e56475
BUG: matrices must be integers
eric-wieser Jul 14, 2017
423e5b5
Move tests to a class
eric-wieser Jul 14, 2017
47144f3
Use the get_next_color method
eric-wieser Jul 14, 2017
60e52cf
Combine faces into a single Poly3DCollection for each voxel
eric-wieser Jul 14, 2017
3c37cfb
Fix PEP8 warnings
eric-wieser Jul 14, 2017
1e73931
Forward keyword arguments onto Poly3DCollection
eric-wieser Jul 14, 2017
df50224
Improve documentation for the color argument
eric-wieser Jul 14, 2017
b6a703b
Fix PEP warnings
eric-wieser Jul 14, 2017
18851b2
Add gallery examples
eric-wieser Jul 15, 2017
b16f70a
Per-voxel edgecolors too. Arguments renamed to match Poly3DCollection
eric-wieser Jul 15, 2017
50d9070
Add support for x,y,z arguments
eric-wieser Jul 16, 2017
0a2f069
DOC: add clearer call signatures
eric-wieser Jul 20, 2017
4003858
TST: Verify all the call signatures work correctly
eric-wieser Jul 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Be explicit about slicing
  • Loading branch information
@eric-wieser
eric-wieser committed Jul 13, 2017
commit 46905769b78e9859a9f85c184e1b0772c6883406
2 changes: 1 addition & 1 deletion lib/mpl_toolkits/mplot3d/axes3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2831,7 +2831,7 @@ def permutation_matrices(n):
boundary_found(p0 + square_rot, color[i0])

# draw middle faces
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a bit more comments here explaining what the extra logic here is for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which extra logic are you referring to? The goal here is to not double-draw a face, which would cause clipping issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly that. "don't double-draw a face" is a nice, clear explanation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment added at the start of this loop

for r1, r2 in zip(rinds, rinds[1:]):
for r1, r2 in zip(rinds[:-1], rinds[1:]):
p1 = permute.dot([p, q, r1])
p2 = permute.dot([p, q, r2])

Expand Down