Fix numpy version tests to use Looseversion #6490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,7 +85,7 @@ def test_formatter_ticker(): | |||
|
|
|||
| @image_comparison(baseline_images=["formatter_large_small"]) | |||
| def test_formatter_large_small(): | |||
| if tuple(map(int, np.__version__.split('.'))) >= (1, 11, 0): | |||
| if LooseVersion(np.__version__) >= LooseVersion(1, 11, 0): | |||
There was a problem hiding this comment.
I think this needs to be LooseVersion('1.11.0')
There was a problem hiding this comment.
I was sure that was what I typed Fixed now
ffe2dae to
dede0df
Compare
|
Failure is one of the mathtext transients. |
|
merged to 2.x while dropping these changes in b9873ab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #6489