Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update mpl_toolkits.gtktools. #6554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2016
Merged

Update mpl_toolkits.gtktools. #6554

merged 1 commit into from
Jun 20, 2016

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 8, 2016

Actually, I'd rather just deprecate/kill gtktools and exceltools, which seem completely unmaintained and with no good reason to be shipped with matplotlib... but in case someone wants to keep them there:

  • On Py2, np.rec.fromarrays cannot take a unicode string as names (but this module __future__-imports unicode_strings).
  • CallbackRegistry ctor signature has changed.

@jenshnielsen
Copy link
Member

@anntzer Thanks I am 👍 on deprecating both of these. Do you want to add that here too?

@anntzer
Copy link
Contributor Author

anntzer commented Jun 8, 2016

Added a deprecation message.

@tacaswell tacaswell added this to the 2.0 (style change major release) milestone Jun 8, 2016
@tacaswell
Copy link
Member

we have exceltools?!?

Maybe suggest using pandas or openpyxl as an alternative to the excel tools?

@anntzer
Copy link
Contributor Author

anntzer commented Jun 8, 2016

It's literally two functions on top of xlrd; I honestly can't imagine that anyone is relying on them... anyways, mentioned openpyxl as a replacement.

@WeatherGod
Copy link
Member

We changed the ctor of CallbackRegistry years ago, IIRC. A bit telling,
methinks.

I also have no objections to deprecating these. I didn't even mention
gtktools in my book (slipped my mind).

On Wed, Jun 8, 2016 at 11:57 AM, Antony Lee [email protected]
wrote:

It's literally two functions on top of xlrd; I honestly can't imagine that
anyone is relying on them... anyways, mentioned openpyxl as a replacement.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6554 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AARy-DXVa_3V7jPwRy7LGPriemVIxnZKks5qJuaEgaJpZM4Iwu4T
.

@tacaswell
Copy link
Member

This needs a rebase (not sure why).

@anntzer
Update & deprecate mpl_toolkits.{gtk,excel}tools.
9572d60 
- On Py2, np.rec.fromarrays cannot take a unicode string as names (but
this module __future__-imports unicode_strings).

- CallbackRegistry ctor signature has changed.
@anntzer
Copy link
Contributor Author

anntzer commented Jun 20, 2016

done

@tacaswell tacaswell merged commit 1214b21 into matplotlib:master Jun 20, 2016
tacaswell added a commit that referenced this pull request Jun 20, 2016
@tacaswell
Merge pull request #6554 from anntzer/fix-gtktools
c1410f9 
MNT: Update mpl_toolkits.gtktools.
@tacaswell
Copy link
Member

backported to v2.x as c1410f9

@anntzer anntzer deleted the fix-gtktools branch June 20, 2016 19:35
@anntzer anntzer mentioned this pull request Oct 16, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @jenshnielsen @tacaswell @WeatherGod @mdboom