RectangleSelector: Handle case when button is still pressed when mouse is not in the axis #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. This looks good to me. I'm going to leave this up for others to experiment with for a while before merging. |
|
RectangleSelector and SpanSelector have a 'visible' property used directly into Rectangle. In RectangleSelector has also an additional property 'active' which is only used in ignore(). Why SpanSelector does not do the same ? |
| if event.button == self.eventpress.button and event.inaxes != self.ax: | ||
| (xdata, ydata) = self.ax.transData.inverted().transform_point((event.x, event.y)) | ||
| xlim = self.ax.get_xlim() | ||
| ylim = self.ax.get_ylim() |
There was a problem hiding this comment.
You need to use self.ax.get_xbound() etc. in place of get_xlim() in case the axis is inverted.
As per Eric Firing comment
jdh2358
added a commit
that referenced
this pull request
Feb 26, 2012
RectangleSelector: Handle case when button is still pressed when mouse is not in the axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the user, it is more convenient to have the RectangleSelector still responsive when not in the axis. However the selection is limited to the axis boundaries.