Fix hinton demo #6606
Merged
Fix hinton demo #6606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Targeting 1.5.x is reasonable, but it looks like you added your commits on top of a checkout of master (which is why this show merging 250+ commits. Can you please cherry-pick your two commits on top v1.5.x and then force-push to your branch. |
|
Thanks for the contribution @copper-head Looks correct to me. It looks like you have done your work on top of the master branch but targeted the 1.5.x branch. That means you have a lot of extra commits on this branch. You can either close this PR and open a new one against the master branch and we will take care of backporting. Alternatively you can cherrypick your commits onto a branch based of 1.5.x |
|
Ah, sorry, I done goofed. Should be fixed now, I think. |
|
Thanks, looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the hinton demo the size of rectangles isn't normalized by
max_weight. This PR fixes this issue and adds some whitespace around operators in the calculation ofmax_weight.After reading the contributor guidelines I chose the 1.5.x branch as the target, feel free to let me know if that's incorrect!