Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH: make antialiased gifs for Tk, and remove unused image files #6627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2016

Conversation

efiring
Copy link
Member

@efiring efiring commented Jun 22, 2016

Closes #6610.

@efiring efiring added this to the 2.0 (style change major release) milestone Jun 22, 2016
@QuLogic
Copy link
Member

QuLogic commented Jun 23, 2016

Why is it called hand.* when it's a cross in a circle? And where is that even used?

@efiring
Copy link
Member Author

efiring commented Jun 23, 2016

Good question, and I don't know the answer. I think it might be the cursor for pan/zoom. Or maybe it is a fossil.

@tacaswell
Copy link
Member

👍 I checked with tk and this does look much better

@tacaswell
Copy link
Member

I did a quick look and I can not find any use of the hand icon (git grep hand[^l] returns only a few hits).

Looking at backend_tkagg the file 'move' has been used for panning as far back as the git history goes (shows up in e34a333) but the comments at https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/backend_bases.py#L2795 imply that hand used to used for panning. That comment also (with minor formatting changes) goes back to e34a333 .

99% sure that the whole hand set is a fossil that we can safely remove. There might be some third-party backends out there that use it?

@tacaswell
Copy link
Member

I am in favor of merging this as-is and dealing with removing hand later.

Do we want to put in an API note for removing the xpm and ppm files?

@efiring
Copy link
Member Author

efiring commented Jun 23, 2016

I see those files as internal implementation details, not API; they were never intended for use outside matplotlib.

@efiring
Copy link
Member Author

efiring commented Jun 23, 2016

I see those files as internal implementation details, not API; they were never intended for use outside matplotlib, as far as I know.

@jenshnielsen jenshnielsen merged commit 11226f8 into matplotlib:v2.x Jun 23, 2016
@efiring efiring deleted the icon_antialias branch June 23, 2016 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants