Remove explicit children invalidation in update_position method #6692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22e7792 to
9eea40f
Compare
| hasattr(self.axes, 'xaxis') and | ||
| self.axes.xaxis.get_scale() != 'linear') | ||
|
|
||
| def update_position(self, x): |
There was a problem hiding this comment.
Please do not change the arg names, it will break anyone who is unpacking dictionaries in to this method.
There was a problem hiding this comment.
Oh, sorry, I though that kwargs cannot be unpacked into positional arguments.
|
appveyor failure is connectivity to anaconda.org issue |
|
I will make a performance test then, but the test suit runs the same amount of time with this change. And as I have mentioned in the commit message |
|
I suspect that (given the age) it was using some internal details that have moved under it. Don't worry about adding a performance test (unless @mdboom disagrees). I think this is otherwise 👍 . |
This invalidation actually does nothing as the `Line2D` does not have nor use the `_invalid` field. There are `_invalidx` and `_invalidy` fields for this purpose, but them are private members. Moreover, the `set_xdata` and `set_ydata` methods internally invalidate the state (what is more reasonable then an external invalidation).
9eea40f to
0847006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This invalidation actually does nothing as the
Line2Ddoes not have nor use the_invalidfield. There are_invalidxand_invalidyfields for this purpose, but them are private members. Moreover, theset_xdataandset_ydatamethods internally invalidate the state (what is more reasonablethen an external invalidation).