DOC: Document verts in scatter
#6963
Conversation
|
So I have to ask, in what units? Pixels? Points? Or between 0 and 1 (and scaled by the size)? |
|
Hi @tacaswell |
b64a0b9 to
99fb603
Compare
|
thanks for the ping, updated and force-pushed. |
| @@ -3811,8 +3811,7 @@ def scatter(self, x, y, s=None, c=None, marker=None, cmap=None, norm=None, | |||
| vmin=None, vmax=None, alpha=None, linewidths=None, | |||
| verts=None, edgecolors=None, | |||
| **kwargs): | |||
| """ | |||
| Make a scatter plot of x vs y, where x and y are sequence like objects | |||
| """Make a scatter plot of x vs y, where x and y are sequence like objects | |||
There was a problem hiding this comment.
Not sure this should have changed.
There was a problem hiding this comment.
I'm pretty sure this will break something, though it may be the dedent_interpd that was removed...
There was a problem hiding this comment.
That indeed can break some indentation thing we have going on, but only if we are appending or interpolating this function.
There was a problem hiding this comment.
Note: the documentation build will fail if that is the case.
| verts : sequence of (x, y), optional | ||
| If `marker` is None, these vertices will be used to | ||
| construct the marker. The center of the marker is located | ||
| at (0,0) and the size is normalized. |
There was a problem hiding this comment.
I think I know, but normalized from what to what? Also, "the size" (as an unqualified term) could be confused with the s parameter.
verts in scatterverts in scatter
|
@tacaswell Excellent questions… I indeed had a pull request adding an element in the notes section about using plot instead of scatter… |
|
It is in the see also section: #7096 |
|
I've got it locally in master, but I can't see it in your file. |
|
Ah, great. That explains why it was not showing up in my file on this branch (as it was forked before that PR was backported). |
|
Were you going to rebase, or is this fine? |
|
It's fine as-is, the changes are non-conflicting. |
verts in scatterverts in scatter
close #6958