FIX: slow plots of pandas objects #6991
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge master into your feature branch, rebase instead. |
|
Also, please split up the units change vs the nan change? |
|
My guess at the problem is length 0 objects making it in, but I am not sure. |
|
Sorry, I didn't know that new commits to my branch are automatically added here... It's the first time I made a pull request to a large project. I will close it for know, clean up the mess and make a new pull request. I will also add a check for zero length objects. |
|
Deleting your fork is a bit extreme. Force-pushing the fixed up commits would have been sufficient. |
|
New PR was #6997. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes loop in unit.py to iterate through all elements in order to find a converter. Closes #6804.