[DOC] update step function documentation #7030
Conversation
| Return value is a list of lines that were added. | ||
| Note | ||
| ---- | ||
| Additional parameters are the same as those for :func:`~matplotlib.pyplot.plot`. |
There was a problem hiding this comment.
This line is slightly too long for our code standard (max 79 character). Can you break it after "for"?
|
Apart from my comment (and the missing test), I think it is good. If you update the pull request, we'll see if the tests pass! Thanks for the patch. |
|
It appears you have not set the config for your git client. All your commits are attributed to "Your Name [email protected]", which is probably not what you want. |
| Other parameters | ||
| --------------------- | ||
| where : [ 'pre' | 'post' | 'mid' ] | ||
| If 'pre' (the default), the interval from |
There was a problem hiding this comment.
There is a trailing space at the end of this line. Can you please remove it?
|
Here's another try. I believe I cleaned the trailing space and tabs. @NelleV |
|
Wohoo ! The tests pass! Congrats! |
|
Yay! |
|
Here is how it looks (the top only):
|
|
The first two commits are still attributed to If you are not comfortable with rebasing to correct that issue, we can take care of it for you before merging if you let us know the name and email to use. |
|
@QuLogic It'd be great if you guys can rebase it for me. Thanks a lot. Below are my details: |
|
I've rebased and created a new PR. I'll merge as soon as the tests finish. |
Hello from the ASPP School. These are our "improvements" to the documentation. @NelleV