Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Replaced documentation with numpydoc for semilogx #7031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Sep 27, 2016
Merged

DOC Replaced documentation with numpydoc for semilogx #7031

merged 3 commits into from Sep 27, 2016

Conversation

ghost
Copy link

@ghost ghost commented Sep 5, 2016

Hello matplotlib!

We have updated the documentation for the semilogx function to numpydoc.

Pavel Soriano & Dorieke Grijseels

@NelleV

`~matplotlib.pyplot.plot`
Log-scaled plot on the *x* axis.

Other Parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a slight indentation problem here. The bottom "---" don't start at the correct place.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually fine. my mistake

@NelleV
Copy link
Member

NelleV commented Sep 5, 2016

Hello!

Your changes unfortunately contain tabs. The tests don't pass, and it also messes the sphinx rendering.
Do you mind editing the file again to remove the tabs?
If you come and see me before the end of the summer school, I can help you with that.

Cheers,
N

@QuLogic
Copy link
Member

QuLogic commented Sep 6, 2016

It appears you have not set the config for your git client. All your commits are attributed to "Your Name [email protected]", which is probably not what you want.

Log-scaled plot on the *x* axis.

Other Parameters
----------------
:class:`~matplotlib.lines.Line2D` properties:

%(Line2D)s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line2D will need to be updated in order for this interpolation to work correctly.

@NelleV
Copy link
Member

NelleV commented Sep 9, 2016

Wohoo! The tests pass!

@NelleV
Copy link
Member

NelleV commented Sep 10, 2016

Here is how it looks (the top part, as my screen is too small to display the whole documentation):

semilogx

Thanks a lot! It's much better than the old version.

@NelleV NelleV changed the title DOC Replaced documentation with numpydoc for semilogx [MRG+1] DOC Replaced documentation with numpydoc for semilogx Sep 14, 2016
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DoriekeMG Are you okay with the commits using your GitHub username instead of your real name?

@QuLogic
Copy link
Member

QuLogic commented Sep 14, 2016

Note that the comments I've left here have already been handled, but GitHub doesn't have a "Mark Resolved" button for comments.

@NelleV NelleV merged commit 82bc35e into matplotlib:master Sep 27, 2016
@QuLogic QuLogic changed the title [MRG+1] DOC Replaced documentation with numpydoc for semilogx DOC Replaced documentation with numpydoc for semilogx Oct 16, 2016
@QuLogic QuLogic added this to the 2.0.1 (next bug fix release) milestone Oct 16, 2016
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull request Oct 16, 2016
DOC Replaced documentation with numpydoc for semilogx
@QuLogic
Copy link
Member

QuLogic commented Oct 16, 2016

Backported to v2.x via f4152ce.

@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants